[CMAKE] Use a stripped binary to build the dist and DMG for OSX
ClosedPublic
Actions

Authored by Fabien on Nov 13 2019, 14:39.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING736aaeedc13d: [CMAKE] Use a stripped binary to build the dist and DMG for OSX
rABC736aaeedc13d: [CMAKE] Use a stripped binary to build the dist and DMG for OSX

Summary

This diff creates a copy of the bitcoin-qt application bundle on OSX,
and strip the executable inside.
This stripped version is then use to build the DMG image.

Depends on D4437.

Test Plan

Build for OSX:

ninja osx-dmg

Check there is a src/qt/stripped directory containing a copy of the
bundle with a stripped binary inside.
Check the dist and DMG binary is stripped.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_osx_strip_copy

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8092
Build 14173: Bitcoin ABC Buildbot (legacy)
Build 14172: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 13 2019, 14:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2019, 14:39

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.Nov 13 2019, 14:41

Harbormaster completed remote builds in B8092: Diff 14102.Nov 13 2019, 14:49

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Nov 17 2019, 22:46

This revision is now accepted and ready to land.Nov 17 2019, 22:46

deadalnix added inline comments.Nov 17 2019, 22:47

src/qt/CMakeLists.txt
362	This seems kinda inefficient, but we'll see in practice if this is a problem. There is already much worse problems tracking dependencies on OSX, so I don't think we should worry about this unless it prove to be a problem.