Use 71 byte signature for DUMMY_SIGNATURE_CREATOR
ClosedPublic
Actions

Authored by deadalnix on Nov 19 2019, 15:15.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING0f5488cfa05d: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR
rABC0f5488cfa05d: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR

Summary

Changes DUMMY_SIGNATURE_CREATOR to create 71 byte dummy signatures.

Update comments to reflect this change

This is a partial backport of Core PR13666 : https://github.com/bitcoin/bitcoin/pull/13666/commits/48b1473c898129a99212e2db36c61cf93625ea17

Depends on D4467

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13666-2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8156
Build 14344: Default Diff Build & Tests
Build 14343: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 19 2019, 15:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2019, 15:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8156: Diff 14201.Nov 19 2019, 15:32

deadalnix added a child revision: D4470: Use 72 byte dummy signatures when watching only inputs may be used.Nov 19 2019, 15:53

jasonbcox accepted this revision.Nov 20 2019, 01:04

This revision is now accepted and ready to land.Nov 20 2019, 01:04

Closed by commit rABC0f5488cfa05d: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyNov 20 2019, 12:38

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC0f5488cfa05d: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR.

deadalnix added a commit: rSTAGING0f5488cfa05d: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR.Apr 7 2020, 21:44

Revision Contents
Changeset List

Path

Size

src/

script/

sign.cpp

14 lines

wallet/

wallet.h

2 lines

wallet.cpp

5 lines

Diff 14201

View Options

src/script/sign.cpp

View Options

src/wallet/wallet.h

View Options

Use 71 byte signature for DUMMY_SIGNATURE_CREATORClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14201

src/script/sign.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

Use 71 byte signature for DUMMY_SIGNATURE_CREATOR
ClosedPublic
Actions

Revision Contents
Changeset List