Page MenuHomePhabricator

Additional sanity checks in SignPSBTInput
ClosedPublic

Authored by deadalnix on Nov 18 2019, 15:17.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd9e677821dc6: Additional sanity checks in SignPSBTInput
Summary

This is a partial backport of Core PR13917 : https://github.com/bitcoin/bitcoin/pull/13917/commits/8254e9950f67d750c7f5905bfdef526d825965ed

Also includes:

Only wipe wrong UTXO type data if overwritten by wallet

https://github.com/bitcoin/bitcoin/pull/13917/commits/c05712cb590c8c76729a71d75a290c67ae9e3c06

Both are extensively prunned due to the absence of segwit.

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Nov 18 2019, 15:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 18 2019, 15:17
Fabien added a subscriber: Fabien.EditedNov 19 2019, 09:18

This is a very weird review, as there is almost nothing from the original PR !

src/wallet/rpcwallet.cpp
5148 ↗(On Diff #14179)

Remove both, as there is no witness/non-witness utxo.

Fabien requested changes to this revision.Nov 19 2019, 09:19
This revision now requires changes to proceed.Nov 19 2019, 09:19
deadalnix updated this revision to Diff 14194.Nov 19 2019, 13:25

Remove 'both'

Fabien accepted this revision.Nov 20 2019, 06:53
Fabien added inline comments.
src/wallet/rpcwallet.cpp
5148 ↗(On Diff #14194)

Nit UTXOs => UTXO

This revision is now accepted and ready to land.Nov 20 2019, 06:53
This revision was automatically updated to reflect the committed changes.