HomePhabricator

Additional sanity checks in SignPSBTInput

Description

Additional sanity checks in SignPSBTInput

Summary:
This is a partial backport of Core PR13917 : https://github.com/bitcoin/bitcoin/pull/13917/commits/8254e9950f67d750c7f5905bfdef526d825965ed

Also includes:

Only wipe wrong UTXO type data if overwritten by wallet

https://github.com/bitcoin/bitcoin/pull/13917/commits/c05712cb590c8c76729a71d75a290c67ae9e3c06

Both are extensively prunned due to the absence of segwit.

Test Plan:

make check
./test/functional/test_runner.py

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4459

Details

Provenance
Pieter Wuille <pieter.wuille@gmail.com>Authored on Aug 8 2018, 21:18
deadalnixCommitted on Nov 20 2019, 12:29
deadalnixPushed on Nov 20 2019, 12:51
Reviewer
Restricted Project
Differential Revision
D4459: Additional sanity checks in SignPSBTInput
Parents
rSTAGING97e226c6db91: Introduce a maximum size for locators.
Branches
Unknown
Tags
Unknown