Page MenuHomePhabricator
Differential D4459

Additional sanity checks in SignPSBTInput
ClosedPublic
Actions

Authored by deadalnix on Nov 18 2019, 15:17.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGd9e677821dc6: Additional sanity checks in SignPSBTInput
rABCd9e677821dc6: Additional sanity checks in SignPSBTInput
Summary

This is a partial backport of Core PR13917 : https://github.com/bitcoin/bitcoin/pull/13917/commits/8254e9950f67d750c7f5905bfdef526d825965ed

Also includes:

Only wipe wrong UTXO type data if overwritten by wallet

https://github.com/bitcoin/bitcoin/pull/13917/commits/c05712cb590c8c76729a71d75a290c67ae9e3c06

Both are extensively prunned due to the absence of segwit.

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13917-nits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8153
Build 14338: Default Diff Build & Tests
Build 14337: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 18 2019, 15:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 18 2019, 15:17
teamcity added a comment.Nov 18 2019, 15:17

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 18 2019, 15:17

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B8144: Diff 14179.Nov 18 2019, 15:28
teamcity added a comment.Nov 18 2019, 15:28

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Nov 18 2019, 15:28

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien added a subscriber: Fabien.EditedNov 19 2019, 09:18

This is a very weird review, as there is almost nothing from the original PR !

src/wallet/rpcwallet.cpp
5148 ↗(On Diff #14179)

Remove both, as there is no witness/non-witness utxo.

Fabien requested changes to this revision.Nov 19 2019, 09:19
This revision now requires changes to proceed.Nov 19 2019, 09:19
deadalnix updated this revision to Diff 14194.Nov 19 2019, 13:25

Remove 'both'

teamcity added a comment.Nov 19 2019, 13:25

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 19 2019, 13:34

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8153: Diff 14194.Nov 19 2019, 13:34
deadalnix added a child revision: D4475: Test that a non-witness script as witness utxo is not signed.Nov 19 2019, 18:07
Fabien accepted this revision.Nov 20 2019, 06:53
Fabien added inline comments.
src/wallet/rpcwallet.cpp
5148

Nit UTXOs => UTXO

This revision is now accepted and ready to land.Nov 20 2019, 06:53
Closed by commit rABCd9e677821dc6: Additional sanity checks in SignPSBTInput (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyNov 20 2019, 12:29
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCd9e677821dc6: Additional sanity checks in SignPSBTInput.
deadalnix added a commit: rSTAGINGd9e677821dc6: Additional sanity checks in SignPSBTInput.Apr 7 2020, 21:44

Revision Contents
Changeset List

PathSize
src/
script/
5 lines
wallet/
3 lines

Diff 14194

View Options

src/script/sign.h

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...