Page MenuHomePhabricator
Differential D4488

[MOVEONLY] Move ParseHDKeypath to utilstrencodings
ClosedPublic
Actions

Authored by deadalnix on Nov 20 2019, 16:18.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING239e9c2a5517: [MOVEONLY] Move ParseHDKeypath to utilstrencodings
rABC239e9c2a5517: [MOVEONLY] Move ParseHDKeypath to utilstrencodings
Summary

This is a partial backport of Core PR13723 : https://github.com/bitcoin/bitcoin/pull/13723/commits/3b01efa0d1bf3d23d1b7b7e518849f1fc26314f9

Depends on D4486

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
movehdkeypath
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8179
Build 14387: Default Diff Build & Tests
Build 14386: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 20 2019, 16:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2019, 16:18
teamcity added a comment.Nov 20 2019, 16:18

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix edited the summary of this revision. (Show Details)Nov 20 2019, 16:22
deadalnix added a parent revision: D4486: Introduce KeyOriginInfo for fingerprint + path.
deadalnix added a child revision: D4491: Implement key origin lookup in CWallet.Nov 20 2019, 16:30
Harbormaster completed remote builds in B8179: Diff 14236.Nov 20 2019, 16:38
teamcity added a comment.Nov 20 2019, 16:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox accepted this revision.Nov 20 2019, 20:03
This revision is now accepted and ready to land.Nov 20 2019, 20:03
Closed by commit rABC239e9c2a5517: [MOVEONLY] Move ParseHDKeypath to utilstrencodings (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyNov 20 2019, 21:21
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC239e9c2a5517: [MOVEONLY] Move ParseHDKeypath to utilstrencodings.
deadalnix added a commit: rSTAGING239e9c2a5517: [MOVEONLY] Move ParseHDKeypath to utilstrencodings.Apr 7 2020, 21:45

Revision Contents
Changeset List

PathSize
src/
util/
4 lines
40 lines
wallet/
40 lines
test/
1 line

Diff 14236

View Options

src/util/strencodings.h

Loading...
View Options

src/util/strencodings.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/psbt_wallet_tests.cpp

Loading...