Make SigningProvider expose key origin information
ClosedPublic
Actions

Authored by deadalnix on Nov 20 2019, 16:21.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGd32a1d5f5fe6: Make SigningProvider expose key origin information
rABCd32a1d5f5fe6: Make SigningProvider expose key origin information

Summary

This is a partial backport of Core PR13723 : https://github.com/bitcoin/bitcoin/pull/13723/commits/84f1f1bfdf900cd28099e428441aa42f9d11a0ed

Depends on D4486

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13723-expose

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8180
Build 14389: Default Diff Build & Tests
Build 14388: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 20 2019, 16:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2019, 16:21

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix added a child revision: D4490: Generalize PublicOnlySigningProvider into HidingSigningProvider.Nov 20 2019, 16:26

Harbormaster completed remote builds in B8180: Diff 14237.Nov 20 2019, 16:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox accepted this revision.Nov 20 2019, 20:07

This revision is now accepted and ready to land.Nov 20 2019, 20:07

Closed by commit rABCd32a1d5f5fe6: Make SigningProvider expose key origin information (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyNov 20 2019, 21:25

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCd32a1d5f5fe6: Make SigningProvider expose key origin information.

deadalnix added a commit: rSTAGINGd32a1d5f5fe6: Make SigningProvider expose key origin information.Apr 7 2020, 21:45

Revision Contents
Changeset List

Path

Size

src/

script/

sign.h

4 lines

sign.cpp

9 lines

Diff 14237

View Options

src/script/sign.h