Make SignPSBTInput operate on a private SignatureData object
ClosedPublic
Actions

Authored by deadalnix on Nov 20 2019, 17:43.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGb386fce87d7b: Make SignPSBTInput operate on a private SignatureData object
rABCb386fce87d7b: Make SignPSBTInput operate on a private SignatureData object

Summary

This is a partial backport of Core PR13723 : https://github.com/bitcoin/bitcoin/pull/13723/commits/917353c8b0eff4cd95f9a5f7719f6756bb8338b1

Depends on Depends on D4493

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13723

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8190
Build 14406: Default Diff Build & Tests
Build 14405: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 20 2019, 17:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2019, 17:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8190: Diff 14257.Nov 20 2019, 18:38

Fabien accepted this revision.Nov 21 2019, 20:07

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/script/sign.h
121	Good catch

This revision is now accepted and ready to land.Nov 21 2019, 20:07

Closed by commit rABCb386fce87d7b: Make SignPSBTInput operate on a private SignatureData object (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyNov 21 2019, 23:20

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCb386fce87d7b: Make SignPSBTInput operate on a private SignatureData object.

deadalnix added a commit: rSTAGINGb386fce87d7b: Make SignPSBTInput operate on a private SignatureData object.Apr 7 2020, 21:47

Revision Contents
Changeset List

Path

Size

src/

rpc/

rawtransaction.cpp

5 lines

script/

sign.h

5 lines

sign.cpp

6 lines

wallet/

rpcwallet.cpp

3 lines

Diff 14257

View Options

src/rpc/rawtransaction.cpp

View Options

src/script/sign.h

View Options

src/script/sign.cpp

View Options

Make SignPSBTInput operate on a private SignatureData objectClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14257

src/rpc/rawtransaction.cpp

src/script/sign.h

src/script/sign.cpp

src/wallet/rpcwallet.cpp

Make SignPSBTInput operate on a private SignatureData object
ClosedPublic
Actions

Revision Contents
Changeset List