Page MenuHomePhabricator
Differential D4536

[cmake] Add comments to express what tests do.
ClosedPublic
Actions

Authored by deadalnix on Nov 25 2019, 17:03.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING82df9cb4a4fc: [cmake] Add comments to express what tests do.
rABC82df9cb4a4fc: [cmake] Add comments to express what tests do.
Summary

The current way of having an echo command before running the test is rather pointless as the echo is only rendered once the test finishes. Presumably, the author of these echo command intended to use the COMMENT directive.

Test Plan
ninja check-bitcoin-util
ninja check-rpcauth
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmaketestcomment
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8265
Build 14555: Default Diff Build & Tests
Build 14554: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 25 2019, 17:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2019, 17:03
Fabien accepted this revision.Nov 25 2019, 17:09
This revision is now accepted and ready to land.Nov 25 2019, 17:09
teamcity added a comment.Nov 25 2019, 17:17

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix updated this revision to Diff 14379.Nov 25 2019, 17:25

rebase

teamcity added a comment.Nov 25 2019, 17:39

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8265: Diff 14375.Nov 25 2019, 17:39
This revision was landed with ongoing or failed builds.Nov 25 2019, 17:58
Closed by commit rABC82df9cb4a4fc: [cmake] Add comments to express what tests do. (authored by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC82df9cb4a4fc: [cmake] Add comments to express what tests do..
teamcity added a comment.Nov 25 2019, 17:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 25 2019, 18:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8267: Diff 14379.Nov 25 2019, 18:10
deadalnix added a commit: rSTAGING82df9cb4a4fc: [cmake] Add comments to express what tests do..Apr 7 2020, 21:49

Revision Contents
Changeset List

PathSize
test/
19 lines

Diff 14375

View Options

test/CMakeLists.txt

Loading...