Page MenuHomePhabricator
Differential D4641

[cuckoocache] Use matchKey instead of the == operator.
ClosedPublic
Actions

Authored by deadalnix on Dec 4 2019, 22:38.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING90d243144c49: [cuckoocache] Use matchKey instead of the == operator.
rABC90d243144c49: [cuckoocache] Use matchKey instead of the == operator.
Summary

We plan to allow for Element to be a key/value pair in order to store informations in the cache. This means simple equality cannot be used anymore.

A wrapper type is provided to add the matchKey feature to any type conveniently.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cuckoomapprepare
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8417
Build 14849: Default Diff Build & Tests
Build 14848: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 4 2019, 22:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 4 2019, 22:38
teamcity added a comment.Dec 4 2019, 22:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 4 2019, 22:56

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8417: Diff 14630.Dec 4 2019, 22:56
teamcity added a comment.Dec 5 2019, 09:33

Build Bitcoin-ABC / Diffs (Staging) / Diff Testing started.

teamcity added a comment.Dec 5 2019, 09:37

Build Bitcoin-ABC / Diffs (Staging) / Diff Testing failed.

Fabien accepted this revision.Dec 5 2019, 10:35
This revision is now accepted and ready to land.Dec 5 2019, 10:35
Closed by commit rABC90d243144c49: [cuckoocache] Use matchKey instead of the == operator. (authored by deadalnix). · Explain WhyDec 5 2019, 13:09
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC90d243144c49: [cuckoocache] Use matchKey instead of the == operator..
markblundeberg mentioned this in D4621: allow cuckoocache to function as a map.Dec 10 2019, 04:36
markblundeberg mentioned this in D4834: add sigChecks value to script cache.Jan 5 2020, 02:54
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABCcdb26502f1fd: add sigChecks value to script cache.Feb 1 2020, 08:10
deadalnix added a commit: rSTAGING90d243144c49: [cuckoocache] Use matchKey instead of the == operator..Apr 7 2020, 21:59
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGcdb26502f1fd: add sigChecks value to script cache.Apr 7 2020, 22:45

Revision Contents
Changeset List

PathSize
src/
17 lines
script/
3 lines
4 lines
test/
20 lines

Diff 14630

View Options

src/cuckoocache.h

Loading...
View Options

src/script/scriptcache.cpp

Loading...
View Options

src/script/sigcache.cpp

Loading...
View Options

src/test/cuckoocache_tests.cpp

Loading...