Page MenuHomePhabricator
Differential D4645

[CMAKE] Make the source control tools inclusion an option
ClosedPublic
Actions

Authored by Fabien on Dec 5 2019, 13:22.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING72112752781a: [CMAKE] Make the source control tools inclusion an option
rABC72112752781a: [CMAKE] Make the source control tools inclusion an option
Summary

And disable it by default. The check-source-control-tools would fail
on systems where bash in not installed. With this diff cmake errors
out with a meaningful message if unavailable.

Test Plan
sed -i 's/bash/trash/g' ../contrib/source-control-tools/CMakeLists.txt

Should work:

cmake -GNinja ..

Should fail:

rm -rf * && cmake -GNinja .. -DBUILD_SOURCE_CONTROL_TOOLS=ON

sed -i 's/trash/bash/g' ../contrib/source-control-tools/CMakeLists.txt

Should Work:

rm -rf * && cmake -GNinja .. -DBUILD_SOURCE_CONTROL_TOOLS=ON
ninja check-source-control-tools

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_option_source_control_tools
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8424
Build 14863: Default Diff Build & Tests
Build 14862: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 5 2019, 13:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 5 2019, 13:22
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 5 2019, 13:36

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 5 2019, 13:49

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8424: Diff 14641.Dec 5 2019, 13:49
jasonbcox accepted this revision.Dec 5 2019, 16:09
This revision is now accepted and ready to land.Dec 5 2019, 16:09
Closed by commit rABC72112752781a: [CMAKE] Make the source control tools inclusion an option (authored by Fabien). · Explain WhyDec 5 2019, 16:32
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC72112752781a: [CMAKE] Make the source control tools inclusion an option.
teamcity added a comment.Dec 5 2019, 16:42

Build Bitcoin-ABC / Diffs (Staging) / Diff Testing started.

teamcity added a comment.Dec 5 2019, 16:50

Build Bitcoin-ABC / Diffs (Staging) / Diff Testing passed.

Fabien added a commit: rSTAGING72112752781a: [CMAKE] Make the source control tools inclusion an option.Apr 7 2020, 21:59

Revision Contents
Changeset List

PathSize
contrib/
6 lines
source-control-tools/
5 lines

Diff 14641

View Options

contrib/CMakeLists.txt

Loading...
View Options

contrib/source-control-tools/CMakeLists.txt

Loading...