Page MenuHomePhabricator
Differential D4701

reduce code duplication in UpdateFlags
ClosedPublic
Actions

Authored by markblundeberg on Dec 11 2019, 21:37.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING695e8e1543b1: reduce code duplication in UpdateFlags
rABC695e8e1543b1: reduce code duplication in UpdateFlags
Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Dec 11 2019, 21:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 11 2019, 21:37
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 11 2019, 21:37

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 11 2019, 21:48

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8512: Diff 14785.Dec 11 2019, 21:48
markblundeberg added inline comments.Dec 11 2019, 21:53
src/validation.cpp
3176 ↗(On Diff #14785)

The idea of having pindexBase here strikes me as odd... but I suppose this is done as some kind of optimization -- it's faster to reject due to nonchanging f(status) than it is to call GetAncestor.

deadalnix accepted this revision.Dec 13 2019, 02:38
This revision is now accepted and ready to land.Dec 13 2019, 02:38
Closed by commit rABC695e8e1543b1: reduce code duplication in UpdateFlags (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyDec 13 2019, 03:52
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC695e8e1543b1: reduce code duplication in UpdateFlags.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING695e8e1543b1: reduce code duplication in UpdateFlags.Apr 7 2020, 22:04

Revision Contents
Changeset List

PathSize
src/
12 lines

Diff 14822

View Options

src/validation.cpp

Loading...