[CMAKE] Fix Qt tests when the wallet is not built
ClosedPublic
Actions

Authored by Fabien on Dec 13 2019, 10:02.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING73b318b6d4d2: [CMAKE] Fix Qt tests when the wallet is not built
rABC73b318b6d4d2: [CMAKE] Fix Qt tests when the wallet is not built

Summary

This diff makes the addressbooktests.cpp to only build when the wallet
is enabled.

Test Plan

cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF
ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_fix_qt_test_no_wallet

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8544
Build 15081: Default Diff Build & Tests
Build 15080: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 13 2019, 10:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 13 2019, 10:02

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4711: [CI] Migrate the CI to use cmake and ninja.Dec 13 2019, 10:05

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8544: Diff 14833.Dec 13 2019, 10:23

jasonbcox accepted this revision.Dec 13 2019, 17:38

This revision is now accepted and ready to land.Dec 13 2019, 17:38

Closed by commit rABC73b318b6d4d2: [CMAKE] Fix Qt tests when the wallet is not built (authored by Fabien). · Explain WhyDec 13 2019, 19:37

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC73b318b6d4d2: [CMAKE] Fix Qt tests when the wallet is not built.

Fabien added a commit: rSTAGING73b318b6d4d2: [CMAKE] Fix Qt tests when the wallet is not built.Apr 7 2020, 22:04

Revision Contents
Changeset List

Path

Size

src/

qt/

test/

CMakeLists.txt

2 lines

Diff 14833

View Options

src/qt/test/CMakeLists.txt

[CMAKE] Fix Qt tests when the wallet is not builtClosedPublicActions