Page MenuHomePhabricator
Differential D4795

Fix heap-use-after-free in activation_tests
ClosedPublic
Actions

Authored by jasonbcox on Dec 21 2019, 02:09.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING31e8c49e22ca: Fix heap-use-after-free in activation_tests
rABC31e8c49e22ca: Fix heap-use-after-free in activation_tests
Summary

CreateChainParams() returns a unique_ptr that ends up with no owner. This patch fixes that.

Test Plan
cmake -GNinja -DCMAKE_BUILD_TYPE=Debug -DENABLE_SANITIZERS=address -DCCACHE=OFF ..
ninja test_bitcoin
./src/test/test_bitcoin --run_test=activation_tests

Before patch: Same failure as seen here: https://build.bitcoinabc.org/viewLog.html?buildId=24568&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterAsan&tab=buildLog&_focus=1047
After patch: No errors detected

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-use-after-free
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8678
Build 15342: Default Diff Build & Tests
Build 15341: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Dec 21 2019, 02:09
Herald added a reviewer: deadalnix. · View Herald TranscriptDec 21 2019, 02:09
teamcity added a comment.Dec 21 2019, 02:09

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 21 2019, 02:09

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 21 2019, 02:26

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix requested changes to this revision.Dec 21 2019, 02:26

Just hold onto the unique_ptr . The Params struct is huge and clearly not meant to be used by value.

This revision now requires changes to proceed.Dec 21 2019, 02:26
teamcity added a comment.Dec 21 2019, 02:28

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8675: Diff 15060.Dec 21 2019, 02:29
jasonbcox updated this revision to Diff 15064.Dec 21 2019, 16:56

Feedback

teamcity added a comment.Dec 21 2019, 16:56

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Dec 21 2019, 16:56
teamcity added a comment.Dec 21 2019, 17:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8678: Diff 15064.Dec 21 2019, 17:11
deadalnix accepted this revision.Dec 22 2019, 03:22
This revision is now accepted and ready to land.Dec 22 2019, 03:22
deadalnix added inline comments.Dec 22 2019, 03:23
src/test/activation_tests.cpp
28

Note that this doesn't follow the convention that is used all over the codebase.

Fabien accepted this revision.Dec 22 2019, 09:02
Fabien added a subscriber: Fabien.

Oups, I missed the issue, thank you for handling this !

Closed by commit rABC31e8c49e22ca: Fix heap-use-after-free in activation_tests (authored by jasonbcox). · Explain WhyDec 22 2019, 17:14
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC31e8c49e22ca: Fix heap-use-after-free in activation_tests.
jasonbcox added a commit: rSTAGING31e8c49e22ca: Fix heap-use-after-free in activation_tests.Apr 7 2020, 22:13

Revision Contents
Changeset List

PathSize
src/
test/
16 lines

Diff 15064

View Options

src/test/activation_tests.cpp

Loading...