Page MenuHomePhabricator
Differential D4886

wallet: detecting duplicate wallet by comparing the db filename.
ClosedPublic
Actions

Authored by Fabien on Jan 10 2020, 17:20.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGbc0f71782091: wallet: detecting duplicate wallet by comparing the db filename.
rABCbc0f71782091: wallet: detecting duplicate wallet by comparing the db filename.
Summary
Fix crash attempting to load the same wallet with different path strings
that resolve to the same absolute path.

More details here:
https://github.com/bitcoin/bitcoin/pull/14552

Backport of core PR14552:
https://github.com/bitcoin/bitcoin/pull/14552/files

Depends on D4885.

Test Plan
ninja check
./test/functional/test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14552
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8834
Build 15643: Default Diff Build & Tests
Build 15642: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 10 2020, 17:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2020, 17:20
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 10 2020, 17:20

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 10 2020, 17:25

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8834: Diff 15298.Jan 10 2020, 17:25
deadalnix accepted this revision.Jan 10 2020, 17:48
This revision is now accepted and ready to land.Jan 10 2020, 17:48
Fabien added a child revision: D4888: Add Clang thread safety annotations for variables guarded by cs_db.Jan 10 2020, 19:20
Closed by commit rABCbc0f71782091: wallet: detecting duplicate wallet by comparing the db filename. (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by Fabien). · Explain WhyJan 10 2020, 21:07
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCbc0f71782091: wallet: detecting duplicate wallet by comparing the db filename..
Fabien added a commit: rSTAGINGbc0f71782091: wallet: detecting duplicate wallet by comparing the db filename..Apr 7 2020, 22:21

Revision Contents
Changeset List

PathSize
src/
wallet/
25 lines
53 lines
12 lines
test/
functional/
4 lines

Diff 15298

View Options

src/wallet/db.h

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...