Page MenuHomePhabricator

Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing.
ClosedPublic

Authored by deadalnix on Jan 17 2020, 12:08.

Details

Summary

Bench_internal was previously incorrect but wasn't detected by
-DVERIFY until PR #551.

This is a backport of secp256k1's PR591

Test Plan
cmake -GNinja .. -DCMAKE_C_FLAGS=-DVERIFY
ninja bench-secp256k1-internal

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 17 2020, 13:17

Snippet of first build failure:

[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_groups.py                        | ✓ Passed  | 14 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_hd.py                            | ✓ Passed  | 3 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_import_rescan.py                 | ✓ Passed  | 3 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_importmulti.py                   | ✓ Passed  | 2 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_importprunedfunds.py             | ✓ Passed  | 2 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_keypool.py                       | ✓ Passed  | 3 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_keypool_topup.py                 | ✓ Passed  | 3 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_labels.py                        | ✓ Passed  | 3 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_listreceivedby.py                | ✓ Passed  | 9 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_listsinceblock.py                | ✓ Passed  | 2 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_listtransactions.py              | ✓ Passed  | 9 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_multiwallet.py                   | ✓ Passed  | 8 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_multiwallet.py --usecli          | ✓ Passed  | 9 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_resendwallettransactions.py      | ✓ Passed  | 1 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_txn_clone.py                     | ✓ Passed  | 3 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_txn_clone.py --mineblock         | ✓ Passed  | 2 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_txn_doublespend.py               | ✓ Passed  | 2 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_txn_doublespend.py --mineblock   | ✓ Passed  | 3 s
[14:05:56] :	 [Step 1/1]  [0m [0;34mwallet_zapwallettxes.py                 | ✓ Passed  | 2 s
[14:05:56] :	 [Step 1/1]  [0m [1m
[14:05:56] :	 [Step 1/1] ALL                                     | ✓ Passed  | 436 s (accumulated) 
[14:05:56] :	 [Step 1/1]  [0mRuntime: 99 s
[14:05:56] :	 [Step 1/1] 
[14:05:56] :	 [Step 1/1] [98/447] Running univalue test suite
[14:05:56] :	 [Step 1/1] PASSED: univalue test suite
[14:05:56] :	 [Step 1/1] [181/447] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
[14:05:56] :	 [Step 1/1] In file included from /usr/include/boost/test/unit_test.hpp:19,
[14:05:56] :	 [Step 1/1]                  from ../src/test/script_tests.cpp:29:
[14:05:56] :	 [Step 1/1] ../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
[14:05:56] :	 [Step 1/1] ../src/test/script_tests.cpp:575:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
[14:05:56] :	 [Step 1/1]  BOOST_AUTO_TEST_CASE(script_build) {
[14:05:56] :	 [Step 1/1]                       ^~~~~~~~~~~~
[14:05:56] :	 [Step 1/1] [211/445] cd /home/teamcity/buildAgent/work/c4a5708f2bae7929/contrib/devtools/chainparams && /usr/bin/python3 ./test_make_chainparams.py
[14:05:56] :	 [Step 1/1] .....
[14:05:56] :	 [Step 1/1] ----------------------------------------------------------------------
[14:05:56] :	 [Step 1/1] Ran 5 tests in 0.001s
[14:05:56] :	 [Step 1/1] 
[14:05:56] :	 [Step 1/1] OK
[14:05:56] :	 [Step 1/1] [215/445] Running bitcoin-seeder-upgrade-activated test suite
[14:05:56] :	 [Step 1/1] PASSED: bitcoin-seeder-upgrade-activated test suite
[14:05:56] :	 [Step 1/1] [216/445] Running bitcoin-seeder test suite
[14:05:56] :	 [Step 1/1] PASSED: bitcoin-seeder test suite
[14:05:56] :	 [Step 1/1] [255/445] bitcoin-upgrade-activated: testing util_tests
[14:05:56] :	 [Step 1/1] FAILED: src/test/CMakeFiles/check-bitcoin-upgrade-activated-util_tests 
[14:05:56] :	 [Step 1/1] cd /home/teamcity/buildAgent/work/c4a5708f2bae7929/build/src/test && /home/teamcity/buildAgent/work/c4a5708f2bae7929/build/src/test/run-util_tests.sh
[14:05:56] :	 [Step 1/1] Running 37 test cases...
[14:05:56] :	 [Step 1/1] Running 37 test cases...
[14:05:56] :	 [Step 1/1] ../src/test/util_tests.cpp(1365): error: in "util_tests/test_LockDirectory": check LockDirectory(dirname, lockname, true) == true has failed [false != true]
[14:05:56] :	 [Step 1/1] 
[14:05:56] :	 [Step 1/1] *** 1 failure is detected in the test module "Bitcoin Test Suite"
[14:05:56] :	 [Step 1/1] [267/445] leveldb: testing db_test
[14:05:56] :	 [Step 1/1] ninja: build stopped: subcommand failed.
[14:05:56] :	 [Step 1/1] *** Output of /tmp/sanitizer_logs/*.log.* ***
[14:05:56]W:	 [Step 1/1] ++ print_sanitizers_log
[14:05:56]W:	 [Step 1/1] ++ for log in "${SAN_LOG_DIR}"/*.log.*
[14:05:56]W:	 [Step 1/1] ++ echo '*** Output of /tmp/sanitizer_logs/*.log.* ***'
[14:05:56]W:	 [Step 1/1] ++ cat '/tmp/sanitizer_logs/*.log.*'
[14:05:56]W:	 [Step 1/1] cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory
[14:05:56]W:	 [Step 1/1] Process exited with code 1
[14:05:56]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
This revision was landed with ongoing or failed builds.Jan 17 2020, 14:06
This revision was automatically updated to reflect the committed changes.