Switch x86_64 asm to use "i" instead of "n" for immediate values.
ClosedPublic
Actions

Authored by deadalnix on Jan 17 2020, 12:17.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGa7b56de6fc3c: Switch x86_64 asm to use "i" instead of "n" for immediate values.
rABCa7b56de6fc3c: Switch x86_64 asm to use "i" instead of "n" for immediate values.

Summary

The constraint "n" is a more obscure setting which is needed for
special cases that don't apply to our use.

Use of "n" exposed some bugs in pre-release versions of clang.
This fixes #594

This is a backport of secp256k1's PR599

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 17 2020, 12:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 12:18

Fabien accepted this revision.Jan 17 2020, 13:44

This revision is now accepted and ready to land.Jan 17 2020, 13:44

Build Bitcoin-ABC / Diffs / Diff Testing started.

This revision was landed with ongoing or failed builds.Jan 17 2020, 14:19

Closed by commit rABCa7b56de6fc3c: Switch x86_64 asm to use "i" instead of "n" for immediate values. (authored by Gregory Maxwell <greg@xiph.org>, committed by deadalnix). · Explain Why

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCa7b56de6fc3c: Switch x86_64 asm to use "i" instead of "n" for immediate values..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9012: Diff 15576.Jan 17 2020, 14:22

deadalnix added a commit: rSTAGINGa7b56de6fc3c: Switch x86_64 asm to use "i" instead of "n" for immediate values..Apr 7 2020, 22:31

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

scalar_4x64_impl.h

6 lines

Diff 15592

View Options

src/secp256k1/src/scalar_4x64_impl.h

Switch x86_64 asm to use "i" instead of "n" for immediate values.ClosedPublicActions