The last callsite is in the check_linker_flags function. Adding the
logic at the callsite allow to remove this function from the API.
There is no change in behavior.
Depends on D4961.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING98e3d4d14b82: [CMAKE] Get rid of `add_compiler_flags_to_var`
rABC98e3d4d14b82: [CMAKE] Get rid of `add_compiler_flags_to_var`
ninja check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cmake_remove_add_compiler_flags_to_var
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 9027 Build 16016: Default Diff Build & Tests Build 16015: arc lint + arc unit
Event Timeline
| cmake/modules/AddCompilerFlags.cmake | ||
|---|---|---|
| 115 | The flag not being supported should be a had fail. | |
| cmake/modules/AddCompilerFlags.cmake | ||
|---|---|---|
| 115 | If there is no unused-command-line-argument warning (GCC) then there is no reason to promote it as an error. It's fine to continue in this case and not fail. | |