[CMAKE] Run wallet tests as part of the check-bitcoin target
ClosedPublic
Actions

Authored by Fabien on Jan 17 2020, 22:29.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGabfdad009c9d: [CMAKE] Run wallet tests as part of the check-bitcoin target
rABCabfdad009c9d: [CMAKE] Run wallet tests as part of the check-bitcoin target

Summary

The wallet tests were build with the test_bitcoin executable but have
been forgotten as part of the check-bitcoin target.

Test Plan

ninja check-bitcoin

Ensure the wallet tests are run.

cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF
ninja check-bitcoin

Ensure the tests are run, but no wallet test.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 17 2020, 22:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 22:29

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Beat me to it. For posterity, this was missed in D4698

This revision is now accepted and ready to land.Jan 17 2020, 22:32

jasonbcox mentioned this in D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.Jan 17 2020, 22:33

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9036: Diff 15627.Jan 17 2020, 22:34

My bad, thanks @deadalnix for finding this: https://reviews.bitcoinabc.org/D5004#inline-30712.

Closed by commit rABCabfdad009c9d: [CMAKE] Run wallet tests as part of the check-bitcoin target (authored by Fabien). · Explain WhyJan 17 2020, 22:37

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCabfdad009c9d: [CMAKE] Run wallet tests as part of the check-bitcoin target.

Fabien added a commit: rSTAGINGabfdad009c9d: [CMAKE] Run wallet tests as part of the check-bitcoin target.Apr 7 2020, 22:33

Revision Contents
Changeset List

Path

Size

src/

test/

CMakeLists.txt

35 lines

Diff 15629

View Options

[CMAKE] Run wallet tests as part of the check-bitcoin targetClosedPublicActions