Page MenuHomePhabricator
Differential D5031

Enable context creation in preallocated memory
ClosedPublic
Actions

Authored by deadalnix on Jan 20 2020, 23:39.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGb2fbe53045f1: Enable context creation in preallocated memory
rABCb2fbe53045f1: Enable context creation in preallocated memory
Summary
  • Prepare for manual memory management in preallocated memory
    • Determine ALIGNMENT more cleverly and move it to util.h
    • Implement manual_malloc() helper function
  • Add size constants for preallocated memory
  • Switch to a single malloc call
  • Support cloning a context into preallocated memory
  • Check arguments of _preallocated functions
  • Add tests for contexts in preallocated memory
  • Export _preallocated functions
  • Move _preallocated functions to separate header
  • Explain caller's obligations for preallocated memory

This is a backport of secp256k1 PR566

Depends on D5030

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secppr566
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9104
Build 16169: Default Diff Build & Tests
Build 16168: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 20 2020, 23:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2020, 23:39
teamcity added a comment.Jan 20 2020, 23:39

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 20 2020, 23:43

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9081: Diff 15695.Jan 20 2020, 23:44
Fabien accepted this revision.Jan 21 2020, 16:46
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/secp256k1/include/secp256k1_preallocated.h
17 ↗(On Diff #15695)

excepts => accepts ?

src/secp256k1/src/tests.c
203 ↗(On Diff #15695)

I know it's just like the PR, but really this code is horrible to read...

This revision is now accepted and ready to land.Jan 21 2020, 16:46
deadalnix added inline comments.Jan 21 2020, 17:01
src/secp256k1/src/tests.c
203 ↗(On Diff #15695)

Yes, 100%

deadalnix added inline comments.Jan 21 2020, 17:02
src/secp256k1/include/secp256k1_preallocated.h
17 ↗(On Diff #15695)

Maybe expects ?

deadalnix updated this revision to Diff 15736.Jan 22 2020, 15:21

rebase

teamcity added a comment.Jan 22 2020, 15:21

Build Bitcoin-ABC / Diffs / Diff Testing started.

This revision was landed with ongoing or failed builds.Jan 22 2020, 15:25
Closed by commit rABCb2fbe53045f1: Enable context creation in preallocated memory (authored by Tim Ruffing <crypto@timruffing.de>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCb2fbe53045f1: Enable context creation in preallocated memory.
teamcity added a comment.Jan 22 2020, 15:26

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9104: Diff 15736.Jan 22 2020, 15:26
deadalnix added a commit: rSTAGINGb2fbe53045f1: Enable context creation in preallocated memory.Apr 7 2020, 22:37

Revision Contents
Changeset List

PathSize
src/
secp256k1/
1 line
include/
35 lines
128 lines
src/
6 lines
6 lines
37 lines
42 lines
13 lines
9 lines
90 lines
114 lines
41 lines

Diff 15736

View Options

src/secp256k1/Makefile.am

Loading...
View Options

src/secp256k1/include/secp256k1.h

Loading...
View Options

src/secp256k1/include/secp256k1_preallocated.h

Loading...
View Options

src/secp256k1/src/ecmult.h

Loading...
View Options

src/secp256k1/src/ecmult_gen.h

Loading...
View Options

src/secp256k1/src/ecmult_gen_impl.h

Loading...
View Options

src/secp256k1/src/ecmult_impl.h

Loading...
View Options

src/secp256k1/src/gen_context.c

Loading...
View Options

src/secp256k1/src/scratch_impl.h

Loading...
View Options

src/secp256k1/src/secp256k1.c

Loading...
View Options

src/secp256k1/src/tests.c

Loading...
View Options

src/secp256k1/src/util.h

Loading...