Page MenuHomePhabricator
Differential D5052

gui: Also log and print messages or questions like bitcoind
ClosedPublic
Actions

Authored by Fabien on Jan 23 2020, 14:00.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGc444e2495c47: gui: Also log and print messages or questions like bitcoind
rABCc444e2495c47: gui: Also log and print messages or questions like bitcoind
Summary
Testing and debugging after shutdown are harder if the node was run
through the gui, because errors and warnings would not be logged to the
debug.log or written to the stderr (as is the case for bitcoind).

Backport of core PR14162

Depends on D5051.

Test Plan
ninja all check

./src/qt/bitcoin-qt -regtest -walletdir=/foo/bar

Check an error message is also displayed to the console.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14162
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9118
Build 16195: Default Diff Build & Tests
Build 16194: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 23 2020, 14:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2020, 14:00
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity edited the summary of this revision. (Show Details)Jan 23 2020, 14:00

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 23 2020, 14:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Jan 23 2020, 14:05

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9118: Diff 15759.Jan 23 2020, 14:05
Fabien mentioned this in D5053: [Tests] Suppress output in test_bitcoin for expected errors.Jan 23 2020, 15:11
jasonbcox accepted this revision.Jan 24 2020, 18:35
This revision is now accepted and ready to land.Jan 24 2020, 18:35
Closed by commit rABCc444e2495c47: gui: Also log and print messages or questions like bitcoind (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJan 24 2020, 20:54
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCc444e2495c47: gui: Also log and print messages or questions like bitcoind.
Fabien mentioned this in rABC1d41f43965e5: [Tests] Suppress output in test_bitcoin for expected errors.Jan 27 2020, 08:51
Fabien added a commit: rSTAGINGc444e2495c47: gui: Also log and print messages or questions like bitcoind.Apr 7 2020, 22:38
Fabien mentioned this in rSTAGING1d41f43965e5: [Tests] Suppress output in test_bitcoin for expected errors.

Revision Contents
Changeset List

PathSize
src/
15 lines
16 lines
qt/
3 lines
4 lines

Diff 15759

View Options

src/noui.h

Loading...
View Options

src/noui.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...