Disable clang-tidy by default
ClosedPublic
Actions

Authored by deadalnix on Feb 5 2020, 17:40.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING33c735931731: Disable clang-tidy by default
rABC33c735931731: Disable clang-tidy by default

Summary

While this doesn't slow down a fresh build by much, this is disastrous when jumping between branches as none of the results are cached and they all need to be recomputed.

Test Plan

Run ninja clean and then ninja with clang-tidy:

real    1m22.667s
user    11m38.143s
sys     0m37.996s

Now the same without clang-tidy:

real    0m28.937s
user    0m46.723s
sys     0m10.769s

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Feb 5 2020, 17:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 5 2020, 17:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

Yeah I get the same kind of timings and as you say, jumping branches gets to be a headache... I caved in finally and turned off the option locally.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9279: Diff 16035.Feb 5 2020, 17:46

I spent a lot of time trying to tweak ccache to make it understand clang-tidy as a compiler command but so far nothing worked.
This is reasonable to disable it by default for now.

This revision is now accepted and ready to land.Feb 5 2020, 17:53

Closed by commit rABC33c735931731: Disable clang-tidy by default (authored by deadalnix). · Explain WhyFeb 5 2020, 19:06

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC33c735931731: Disable clang-tidy by default.

deadalnix added a commit: rSTAGING33c735931731: Disable clang-tidy by default.Apr 7 2020, 22:49