Page MenuHomePhabricator
Differential D5237

[avalanche_tests] fix block index accesses
ClosedPublic
Actions

Authored by markblundeberg on Feb 10 2020, 12:36.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING72c1315ac8c6: [avalanche_tests] fix block index accesses
rABC72c1315ac8c6: [avalanche_tests] fix block index accesses
Summary

In preparation for D5238: these should be locked, and we don't need [] operator insertion so let's use the usual lookup function.

Test Plan
CC=clang CXX=clang++ cmake -GNinja .. -DCMAKE_BUILD_TYPE=Debug
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalock
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9383
Build 16697: Default Diff Build & Tests
Build 16696: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 10 2020, 12:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 10 2020, 12:36
teamcity added a comment.Feb 10 2020, 12:36

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a child revision: D5238: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex.Feb 10 2020, 12:45
teamcity added a comment.Feb 10 2020, 12:46

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9383: Diff 16207.Feb 10 2020, 12:46
markblundeberg edited the summary of this revision. (Show Details)Feb 10 2020, 12:46
deadalnix accepted this revision.Feb 10 2020, 14:01
This revision is now accepted and ready to land.Feb 10 2020, 14:01
Closed by commit rABC72c1315ac8c6: [avalanche_tests] fix block index accesses (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 10 2020, 15:24
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC72c1315ac8c6: [avalanche_tests] fix block index accesses.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING72c1315ac8c6: [avalanche_tests] fix block index accesses.Apr 7 2020, 22:56

Revision Contents
Changeset List

PathSize
src/
test/
51 lines

Diff 16207

View Options

src/test/avalanche_tests.cpp

Loading...