Fix a race condition with rpc ports in check-seeds
ClosedPublic
Actions

Authored by jasonbcox on Feb 11 2020, 22:13.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING7f63be6a4ba6: Fix a race condition with rpc ports in check-seeds
rABC7f63be6a4ba6: Fix a race condition with rpc ports in check-seeds

Summary

The RPC port from the first run of test-seeds is not guaranteed to be closed/cleaned up
by the OS by the time the second run on test-seeds occurs. Without this patch, check-seeds is flaky
and fails at random.

Test Plan

ABC_BUILD_NAME=check-seeds ./build-configuration.sh

Run this a few times on CI too

Diff Detail

Repository

rABC Bitcoin ABC

Branch

check-seeds-race

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9449
Build 16819: Default Diff Build & Tests
Build 16818: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 11 2020, 22:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 11 2020, 22:13

jasonbcox planned changes to this revision.Feb 11 2020, 22:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9449: Diff 16307.Feb 11 2020, 22:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox requested review of this revision.Feb 11 2020, 22:35

Fabien accepted this revision.Feb 13 2020, 09:48

This revision is now accepted and ready to land.Feb 13 2020, 09:48

Closed by commit rABC7f63be6a4ba6: Fix a race condition with rpc ports in check-seeds (authored by jasonbcox). · Explain WhyFeb 13 2020, 16:49

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC7f63be6a4ba6: Fix a race condition with rpc ports in check-seeds.

jasonbcox added a commit: rSTAGING7f63be6a4ba6: Fix a race condition with rpc ports in check-seeds.Apr 7 2020, 22:59

Revision Contents
Changeset List

Path

Size

contrib/

seeds/

test-seeds.sh

7 lines

teamcity/

build-configurations.sh

6 lines

Diff 16307

View Options

contrib/seeds/test-seeds.sh