Page MenuHomePhabricator
Differential D5277

Merge #14460: tests: Improve 'CAmount' tests
ClosedPublic
Actions

Authored by nakihito on Feb 12 2020, 21:45.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGe584d180ab73: Merge #14460: tests: Improve 'CAmount' tests
rABCe584d180ab73: Merge #14460: tests: Improve 'CAmount' tests
Summary

29ed2d64f6 Improve CAmount tests (Hennadii Stepanov)

Pull request description:

This provides:
  - more `MoneyRange` tests;
  - explicit using of the `CAmount` type.

Tree-SHA512: ca0ad6ccb37909a2a5c11034dc07b316a84c32fb40c6f8b6cfc28ebec72a1de157f31d22e767ae80d70ed06d7296f23870cc5ed0689f34a754ae763d50e23d43

Backport of Core PR14460
https://github.com/bitcoin/bitcoin/pull/14460/

Adjusted for our codebase.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14460
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9483
Build 16879: Default Diff Build & Tests
Build 16878: arc lint + arc unit

Event Timeline

nakihito created this revision.Feb 12 2020, 21:45
Owners added a reviewer: Restricted Owners Package.Feb 12 2020, 21:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 12 2020, 21:45
teamcity edited the summary of this revision. (Show Details)Feb 12 2020, 21:45

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 12 2020, 21:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 12 2020, 21:54

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9465: Diff 16331.Feb 12 2020, 21:54
Fabien added a subscriber: Fabien.Feb 13 2020, 09:30

Part of the PR is missing (new cases for the CFeeRate constructor).

Fabien requested changes to this revision.Feb 13 2020, 09:31
This revision now requires changes to proceed.Feb 13 2020, 09:31
nakihito updated this revision to Diff 16361.Feb 13 2020, 19:26

Added CFeeRate changes.

teamcity added a comment.Feb 13 2020, 19:26

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 13 2020, 19:42

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9483: Diff 16361.Feb 13 2020, 19:42
Fabien requested changes to this revision.Feb 13 2020, 20:17
Fabien added inline comments.
src/test/feerate_tests.cpp
66

All these casts are useless, since the multiplication operator int * Amount is defined and returns an Amount.

This revision now requires changes to proceed.Feb 13 2020, 20:17
nakihito updated this revision to Diff 16366.Feb 13 2020, 20:32

Removed type casts.

teamcity added a comment.Feb 13 2020, 20:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 13 2020, 21:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9485: Diff 16366.Feb 13 2020, 21:01
Fabien accepted this revision.Feb 14 2020, 09:42
This revision is now accepted and ready to land.Feb 14 2020, 09:42
Closed by commit rABCe584d180ab73: Merge #14460: tests: Improve 'CAmount' tests (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyFeb 14 2020, 18:33
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCe584d180ab73: Merge #14460: tests: Improve 'CAmount' tests.
nakihito added a commit: rSTAGINGe584d180ab73: Merge #14460: tests: Improve 'CAmount' tests.Apr 7 2020, 23:01

Revision Contents
Changeset List

PathSize
src/
test/
4 lines
43 lines

Diff 16361

View Options

src/test/amount_tests.cpp

Loading...
View Options

src/test/feerate_tests.cpp

Loading...