Differential D5302

Failing functional tests stop lcov
ClosedPublic
Actions

Authored by Fabien on Feb 17 2020, 16:09.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGebdfa98dc446: Failing functional tests stop lcov
rABCebdfa98dc446: Failing functional tests stop lcov

Summary

Functional tests can fail and lcov still generates a coverage file,
which is inaccurate. This change stops make from proceeding if
functional tests fail.

Backport of core PR16207.

Test Plan

../configure --enable-lcov
make

Edit a functional test so that it will fail.

make cov

Check the coverage report process is aborted.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR16207

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9521
Build 16954: Default Diff Build & Tests
Build 16953: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 17 2020, 16:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 17 2020, 16:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9521: Diff 16426.Feb 17 2020, 16:19

jasonbcox accepted this revision.Feb 19 2020, 22:53

This revision is now accepted and ready to land.Feb 19 2020, 22:53

Closed by commit rABCebdfa98dc446: Failing functional tests stop lcov (authored by Aseem Sood <asood123@yahoo.com>, committed by Fabien). · Explain WhyFeb 20 2020, 12:54

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCebdfa98dc446: Failing functional tests stop lcov.

Fabien added a commit: rSTAGINGebdfa98dc446: Failing functional tests stop lcov.Apr 7 2020, 23:04

Revision Contents
Changeset List

Path

Size

Makefile.am

2 lines

Diff 16426

View Options

Failing functional tests stop lcovClosedPublicActions