HomePhabricator

Failing functional tests stop lcov

Description

Failing functional tests stop lcov

Summary:

Functional tests can fail and lcov still generates a coverage file,
which is inaccurate. This change stops make from proceeding if
functional tests fail.

Backport of core PR16207.

Test Plan:

../configure --enable-lcov
make

Edit a functional test so that it will fail.

make cov

Check the coverage report process is aborted.

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D5302

Details

Provenance
Aseem Sood <asood123@yahoo.com>Authored on Jun 13 2019, 15:39
FabienCommitted on Feb 20 2020, 12:53
deadalnixPushed on Feb 20 2020, 23:40
Reviewer
Restricted Project
Differential Revision
D5302: Failing functional tests stop lcov
Parents
rSTAGING1b90ab7f06be: [SECP256K1] Fix ability to compile tests without -DVERIFY.
Branches
Unknown
Tags
Unknown