Page MenuHomePhabricator
Differential D5305

Clear the IFP bip in the version by default to avoid accidental activation
ClosedPublic
Actions

Authored by deadalnix on Feb 19 2020, 00:45.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING6521e26b4201: Clear the IFP bip in the version by default to avoid accidental activation
rABC6521e26b4201: Clear the IFP bip in the version by default to avoid accidental activation
Summary

While the defautl behavior of BIP9 is to vote yes by default, it is preferable to avoid doing so accidentaly.

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
versionactivation
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9526
Build 16964: Default Diff Build & Tests
Build 16963: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 19 2020, 00:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 19 2020, 00:45
teamcity added a comment.Feb 19 2020, 00:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 19 2020, 00:55

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9526: Diff 16437.Feb 19 2020, 00:55
jasonbcox accepted this revision.Feb 19 2020, 01:18
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.cpp
1640

Nit: This comment could be more descriptive of why these bits should be cleared.

test/functional/abc-block-sigchecks-activation.py
73

not related, but this is just lint so I guess it doesn't really matter

This revision is now accepted and ready to land.Feb 19 2020, 01:18
Closed by commit rABC6521e26b4201: Clear the IFP bip in the version by default to avoid accidental activation (authored by deadalnix). · Explain WhyFeb 19 2020, 11:13
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC6521e26b4201: Clear the IFP bip in the version by default to avoid accidental activation.
deadalnix added a commit: rSTAGING6521e26b4201: Clear the IFP bip in the version by default to avoid accidental activation.Apr 7 2020, 23:04

Revision Contents
Changeset List

PathSize
src/
3 lines
test/
functional/
3 lines

Diff 16437

View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-block-sigchecks-activation.py

Loading...