Page MenuHomePhabricator

[backport] trivial: Mark overrides as such. #13282
ClosedPublic

Authored by majcosta on Mar 3 2020, 19:56.

Details

Reviewers
nakihito
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGf0513e9cbebe: [backport] trivial: Mark overrides as such. #13282
rABCf0513e9cbebe: [backport] trivial: Mark overrides as such. #13282
Summary

60ebc7da4c trivial: Mark overrides as such. (Daniel Kraft)

Pull request description:

This trivial change adds the override keyword to some methods that override virtual base class / interface methods. This ensures that any future changes to the interface's method signatures which are not correctly mirrored in the subclasses will break at compile time with a clear error message, rather than at runtime.


This is a backport of Core PR13282

Test Plan
ninja check
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
mark_overrides
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9713
Build 17319: Default Diff Build & Tests
Build 17318: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 19:56

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Mar 4 2020, 08:22