Page MenuHomePhabricator

[SECP256K1] Request --enable-experimental for the multiset module
ClosedPublic

Authored by Fabien on Mar 4 2020, 20:39.

Details

Summary

The module is advertised as experimental, but is missing the check for
--enable-experimental like the other experimental modules.
Also disable it by default with cmake (which is the autotools behavior),
as it is more in accordance with its experimental status.

Depends on D5429.

Test Plan
../configure --enable-module-multiset

Check it fails with a message asking for --enable-experimental.

../configure --enable-module-multiset --enable-experimental
make check

cmake -GNinja .. -DSECP256K1_ENABLE_MODULE_MULTISET=ON
ninja check-secp256k1

cmake -GNinja ..
ninja check-secp256k1

Run the Travis build (see https://travis-ci.org/Fabcien/secp256k1/builds/658346030).

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secp256k1_multiset_off_default
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9732
Build 17351: Default Diff Build & Tests
Build 17350: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 5 2020, 16:52