Page MenuHomePhabricator
Differential D5451

[CMAKE] Improve FindQREncode
ClosedPublic
Actions

Authored by Fabien on Mar 9 2020, 13:22.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGde82823f83a2: [CMAKE] Improve FindQREncode
rABCde82823f83a2: [CMAKE] Improve FindQREncode
Summary

Find qrencode on the model of D5339. There is no version information
that can be extracted from the library, so the only benefit here is the
imported target and consistency with other modules.

Test Plan
ninja check

Build on OSX.
Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_find_qrencode
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9785
Build 17443: Default Diff Build & Tests
Build 17442: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 9 2020, 13:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 9 2020, 13:22
teamcity added a comment.Mar 9 2020, 13:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien updated this revision to Diff 16842.Mar 9 2020, 13:30

Rebase on top of D5448 to make the windows gitian build happy.

teamcity added a comment.Mar 9 2020, 13:30

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 9 2020, 13:40

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Mar 9 2020, 13:40

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9766: Diff 16842.Mar 9 2020, 13:40
teamcity added a comment.Mar 9 2020, 13:43

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Mar 9 2020, 13:44

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Mar 9 2020, 13:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9765: Diff 16841.Mar 9 2020, 13:44
teamcity added a comment.Mar 9 2020, 13:47

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Mar 9 2020, 13:52

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Mar 9 2020, 13:54

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

jasonbcox accepted this revision.Mar 11 2020, 03:09
This revision is now accepted and ready to land.Mar 11 2020, 03:09
jasonbcox added a comment.Mar 11 2020, 03:11

Consider adding a TODO for the version number check, similar to what you have in https://reviews.bitcoinabc.org/D5452#change-1AwvRCc5Q4iq

Fabien updated this revision to Diff 16872.Mar 11 2020, 11:08

Add comment.

teamcity added a comment.Mar 11 2020, 11:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 11 2020, 11:20

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9785: Diff 16872.Mar 11 2020, 11:20
Closed by commit rABCde82823f83a2: [CMAKE] Improve FindQREncode (authored by Fabien). · Explain WhyMar 11 2020, 15:44
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCde82823f83a2: [CMAKE] Improve FindQREncode.
Fabien added a commit: rSTAGINGde82823f83a2: [CMAKE] Improve FindQREncode.Apr 7 2020, 23:18

Revision Contents
Changeset List

PathSize
cmake/
modules/
67 lines
src/
config/
1 line
qt/
4 lines

Diff 16872

View Options

cmake/modules/FindQREncode.cmake

Loading...
View Options

src/config/CMakeLists.txt

Loading...
View Options

src/qt/CMakeLists.txt

Loading...