Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Maniphest Tasks
- T762: Build Bitcoin-ABC / Master / Bitcoin-ABC Master ASAN is broken.
T763: Build Bitcoin-ABC / Master / Bitcoin-ABC Master UBSAN is broken.
T764: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. - Commits
- rSTAGINGf8b0f9874998: Add << operator overload for PeerMessagingState
rABCf8b0f9874998: Add << operator overload for PeerMessagingState
ninja check
Run sanitizer builds
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- fixMaster
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 9807 Build 17487: Default Diff Build & Tests Build 17486: arc lint + arc unit
Event Timeline
| src/seeder/bitcoin.cpp | ||
|---|---|---|
| 23 ↗ | (On Diff #16908) | IMO you should separate the C++ magic from the intent of the code, because right now, that is not very clear. For instance, you could use something like: template<typename E>
constexpr std::underlying_type<E>::type to_integral(E e) {
return static_cast<typename std::underlying_type<E>::type>(e);
}And then call that. If it turns out to be more generally useful, then it can be moved to a header somewhere. |
| src/seeder/bitcoin.h | ||
| 12 ↗ | (On Diff #16908) | ostream only is suffiscient. |
| 14 ↗ | (On Diff #16908) | Remove. |
| src/seeder/bitcoin.h | ||
|---|---|---|
| 25 | Nit: Same feedback as https://reviews.bitcoinabc.org/D5471#inline-33727 | |
Comment Actions
Moved to_integral() to a new file. because it is only really used for tests. This makes it easier to include in all (appropriate) test files without having to expose or open up more components.
| src/seeder/bitcoin.h | ||
|---|---|---|
| 22 ↗ | (On Diff #16927) | You missed the bool here |