Page MenuHomePhabricator
Differential D5513

depends: switch to secure download of all dependencies
ClosedPublic
Actions

Authored by Fabien on Mar 19 2020, 14:46.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf568f26f4105: depends: switch to secure download of all dependencies
rABCf568f26f4105: depends: switch to secure download of all dependencies
Summary
Some dependency sources were downloaded via http, even though https
(SSL/TLS) options are available.
Even if we potentially check the integrity of the downloaded files via
hash comparison, we should make use of this additional security layer.

Backport of core PR16049.

Depends on D5504.

Test Plan

Run the Gitian build twice, check the result is deterministic.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR16049
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9886
Build 17632: Default Diff Build & Tests
Build 17631: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 19 2020, 14:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2020, 14:46
teamcity edited the summary of this revision. (Show Details)Mar 19 2020, 14:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 19 2020, 14:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix accepted this revision.Mar 19 2020, 14:49
This revision is now accepted and ready to land.Mar 19 2020, 14:49
teamcity added a comment.Mar 19 2020, 14:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9886: Diff 17037.Mar 19 2020, 14:59
Closed by commit rABCf568f26f4105: depends: switch to secure download of all dependencies (authored by Ulrich Kempken <Uli.Kempken@t-online.de>, committed by Fabien). · Explain WhyMar 19 2020, 15:46
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf568f26f4105: depends: switch to secure download of all dependencies.
Fabien added a commit: rSTAGINGf568f26f4105: depends: switch to secure download of all dependencies.Apr 7 2020, 23:22

Revision Contents
Changeset List

PathSize
depends/
5 lines
packages/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines

Diff 17037

View Options

depends/packages.md

Loading...
View Options

depends/packages/bdb.mk

Loading...
View Options

depends/packages/fontconfig.mk

Loading...
View Options

depends/packages/freetype.mk

Loading...
View Options

depends/packages/libX11.mk

Loading...
View Options

depends/packages/libXau.mk

Loading...
View Options

depends/packages/libXext.mk

Loading...
View Options

depends/packages/libxcb.mk

Loading...
View Options

depends/packages/miniupnpc.mk

Loading...
View Options

depends/packages/native_cctools.mk

Loading...
View Options

depends/packages/native_cdrkit.mk

Loading...
View Options

depends/packages/xcb_proto.mk

Loading...
View Options

depends/packages/xextproto.mk

Loading...
View Options

depends/packages/xproto.mk

Loading...
View Options

depends/packages/xtrans.mk

Loading...
View Options

depends/packages/zlib.mk

Loading...