Fix remaining test_bitcoin.cpp references (should be setup_common.cpp)
ClosedPublic
Actions

Authored by Fabien on Mar 19 2020, 18:00.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING561eefdbe8d2: Fix remaining test_bitcoin.cpp references (should be setup_common.cpp)
rABC561eefdbe8d2: Fix remaining test_bitcoin.cpp references (should be setup_common.cpp)

Summary

Due to out of order landing of D5494, some reference were not updated.

Test Plan

export CC=clang CXX=clang++

../configure --enable-fuzz --with-sanitizers=fuzzer,address \
  --disable-wallet \
  --disable-bench \
  --with-utils=no \
  --with-daemon=no \
  --with-libs=no \
  --with-gui=no \
  --with-seeder=no \
  --with-miniupnpc=no  \
  --disable-zmq
make

cmake -GNinja .. -DENABLE_SANITIZERS="address;fuzzer" \
  -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
ninja bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_setup_common

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9889
Build 17638: Default Diff Build & Tests
Build 17637: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 19 2020, 18:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2020, 18:00

jasonbcox accepted this revision.Mar 19 2020, 18:04

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/Makefile.test.include
62	I should point out that I did bring this up here: https://reviews.bitcoinabc.org/D5494#inline-34018

This revision is now accepted and ready to land.Mar 19 2020, 18:04

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien added inline comments.Mar 19 2020, 18:07

src/Makefile.test.include
62	My bad, I didn't understand the comment in D5494, just thought you were asking where the fuzz line came from

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9889: Diff 17051.Mar 19 2020, 18:15

Closed by commit rABC561eefdbe8d2: Fix remaining test_bitcoin.cpp references (should be setup_common.cpp) (authored by Fabien). · Explain WhyMar 19 2020, 18:16

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC561eefdbe8d2: Fix remaining test_bitcoin.cpp references (should be setup_common.cpp).

Fabien edited the test plan for this revision. (Show Details)Mar 19 2020, 18:26

jasonbcox mentioned this in D5519: Fix missing rename in fuzz test suite.Mar 20 2020, 15:31

jasonbcox mentioned this in rABC9c4b38610f7a: Fix missing rename in fuzz test suite.Mar 20 2020, 15:32

Fabien added a commit: rSTAGING561eefdbe8d2: Fix remaining test_bitcoin.cpp references (should be setup_common.cpp).Apr 7 2020, 23:24

jasonbcox mentioned this in rSTAGING9c4b38610f7a: Fix missing rename in fuzz test suite.Apr 7 2020, 23:24

Revision Contents
Changeset List

Path

Size

src/

Makefile.test.include

2 lines

test/

fuzz/

CMakeLists.txt

2 lines

Diff 17051

View Options

src/Makefile.test.include