Page MenuHomePhabricator
Differential D5587

Disable thread_local for i686-mingw
ClosedPublic
Actions

Authored by Fabien on Mar 27 2020, 12:56.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGe409be178eae: Disable thread_local for i686-mingw
rABCe409be178eae: Disable thread_local for i686-mingw
Summary

This is a follow-up for D5540. Despite the tests passing, the diff is
causing bitcoin-qt to fail quickly. Disabling thread_local for this
compiler fixes the issue.

The code is extracted from PR15849, but the tests for thread_local is a
simplified version.

Test Plan

Build for win32 with autotools and cmake. Run bitcoin-qt and check it
doesn't crash.

As a sanity check, build for win64 and any linux and check
thread_local is enabled.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15849_continued
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10013
Build 17872: Default Diff Build & Tests
Build 17871: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 27 2020, 12:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2020, 12:56
teamcity edited the summary of this revision. (Show Details)Mar 27 2020, 12:56

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 27 2020, 12:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 27 2020, 13:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10006: Diff 17240.Mar 27 2020, 13:09
jasonbcox accepted this revision.Mar 27 2020, 15:30
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/util/threadnames.cpp
52 ↗(On Diff #17240)

Nit: Missing comment // Without thread_local available, don't handle internal name at all.

This revision is now accepted and ready to land.Mar 27 2020, 15:30
Fabien updated this revision to Diff 17250.Mar 27 2020, 15:34

Add missing comment.

teamcity added a comment.Mar 27 2020, 15:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

This revision was landed with ongoing or failed builds.Mar 27 2020, 15:36
Closed by commit rABCe409be178eae: Disable thread_local for i686-mingw (authored by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe409be178eae: Disable thread_local for i686-mingw.
teamcity added a comment.Mar 27 2020, 15:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10013: Diff 17250.Mar 27 2020, 15:44
jasonbcox mentioned this in D5612: Remove Windows 32 bit build.Mar 30 2020, 19:21
Fabien added a reverting change: D5635: Revert "Disable thread_local for i686-mingw".Apr 1 2020, 13:33
Fabien added a reverting change: rABC6330d8ccc8b1: Revert "Disable thread_local for i686-mingw".Apr 1 2020, 17:36
Fabien added a commit: rSTAGINGe409be178eae: Disable thread_local for i686-mingw.Apr 7 2020, 23:30
Fabien added a reverting change: rSTAGING6330d8ccc8b1: Revert "Disable thread_local for i686-mingw".Apr 7 2020, 23:34

Revision Contents
Changeset List

PathSize
15 lines
src/
config/
10 lines
2 lines
test/
5 lines
util/
15 lines

Diff 17250

View Options

configure.ac

Loading...
View Options

src/config/CMakeLists.txt

Loading...
View Options

src/config/bitcoin-config.h.cmake.in

Loading...
View Options

src/test/util_threadnames_tests.cpp

Loading...
View Options

src/util/threadnames.cpp

Loading...