Page MenuHomePhabricator

Remove Windows 32 bit build
ClosedPublic

Authored by Fabien on Mar 30 2020, 16:48.

Details

Summary

The win32 target will no longer be part of our release nor officially
supported.

It is still possible for users to run the build by themselves, but the
instructions are removed from the doc in order to reflect the
"unsupported" status of this target.

Backport of core PR15939.

Depends on D5610.

Test Plan

Run the Windows Gitian build. Check the win32 binaries are no longer
part of the output.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mar 30 2020, 16:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2020, 16:48
teamcity edited the summary of this revision. (Show Details)Mar 30 2020, 16:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox requested changes to this revision.Mar 30 2020, 19:21
jasonbcox added a subscriber: jasonbcox.

We require a similar change to https://github.com/bitcoin/bitcoin/pull/15939/files#diff-ff7aa83852bca28e4ff420bc97c6cf7c in contrib/teamcity/setup-debian-buster.sh You happened to catch me mid-migration, so you wouldn't see test failures for this quite yet. If you'd prefer to coordinate on this in separate diff, let me know.

This revision now requires changes to proceed.Mar 30 2020, 19:21

Also, summarizing a discussion I had with Fabien offline:
I'm of the opinion that cleaning up our codebase to get rid of 32-bit-supporting features (like reverting D5587 for example) would put us in a better state. It improves code readability to simply not have these sorts of changes when they aren't needed. Currently, our assumptions are that C++11 is well supported. Reverting D5587 would also be in line with the same spirit as D2219, which had a similar removal. However, cleaning this up too aggressively has two factors that oppose this: merge conflicts when backporting, and sudden breakage of support for 32-bit Windows. While the release containing this change will no longer support 32-bit, it seems prudent to not immediately break it while these users (if any) transition.

Fabien prefers to go through a transition period where we do not deliberately break 32-bits to our knowledge. Personally, I don't agree but do not feel the upsides to be strictly strong enough to block this change.

Fabien requested review of this revision.Mar 31 2020, 12:39

@jasonbcox We will remove the i686 arch when we remove linux 32.

jasonbcox requested changes to this revision.Mar 31 2020, 16:38
jasonbcox added inline comments.
depends/README.md
50 ↗(On Diff #17285)

Remove Win32

doc/build-windows.md
168 ↗(On Diff #17285)

Win32 -> Win64

186 ↗(On Diff #17285)

This paragraph needs updating.

This revision now requires changes to proceed.Mar 31 2020, 16:38
Fabien updated this revision to Diff 17325.Mar 31 2020, 16:45

Fix remaining win32 references in docs.

jasonbcox accepted this revision.Mar 31 2020, 22:25
This revision is now accepted and ready to land.Mar 31 2020, 22:25
Fabien updated this revision to Diff 17351.Apr 1 2020, 13:07

Rebase.

This revision was automatically updated to reflect the committed changes.