Page MenuHomePhabricator

Disable thread_local for i686-mingw
ClosedPublic

Authored by Fabien on Mar 27 2020, 12:56.

Details

Summary

This is a follow-up for D5540. Despite the tests passing, the diff is
causing bitcoin-qt to fail quickly. Disabling thread_local for this
compiler fixes the issue.

The code is extracted from PR15849, but the tests for thread_local is a
simplified version.

Test Plan

Build for win32 with autotools and cmake. Run bitcoin-qt and check it
doesn't crash.

As a sanity check, build for win64 and any linux and check
thread_local is enabled.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mar 27 2020, 12:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2020, 12:56
teamcity edited the summary of this revision. (Show Details)Mar 27 2020, 12:56

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox accepted this revision.Mar 27 2020, 15:30
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/util/threadnames.cpp
52 ↗(On Diff #17240)

Nit: Missing comment // Without thread_local available, don't handle internal name at all.

This revision is now accepted and ready to land.Mar 27 2020, 15:30
Fabien updated this revision to Diff 17250.Mar 27 2020, 15:34

Add missing comment.

This revision was landed with ongoing or failed builds.Mar 27 2020, 15:36
This revision was automatically updated to reflect the committed changes.