Page MenuHomePhabricator

contrib: Fix test-security-check fail in Ubuntu 18.04
ClosedPublic

Authored by Fabien on Mar 30 2020, 15:12.

Details

Summary
 - Fix test-security-check fail in Ubuntu 18.04. Those flags are enabled
by default, so we must specify -no to make the executable does 'not'
have those attributes.
 - Drop HIGH_ENTROPY_VA. After update our gitian system to Bionic, the
compiler should support HIGH_ENTROPY_VA

Backport of core PR13764.

Depends on D5609.

Test Plan

Tested on Ubuntu 18.04 and Debian 10:

cd contrib/devtools
./test-security-check.py

cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win32.cmake
  -DBUILD_BITCOIN_SEEDER=OFF
ninja security-check

cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake
  -DBUILD_BITCOIN_SEEDER=OFF
ninja security-check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Mar 30 2020, 18:36