HomePhabricator

contrib: Fix test-security-check fail in Ubuntu 18.04

Description

contrib: Fix test-security-check fail in Ubuntu 18.04

Summary:

 - Fix test-security-check fail in Ubuntu 18.04. Those flags are enabled
by default, so we must specify -no to make the executable does 'not'
have those attributes.
 - Drop HIGH_ENTROPY_VA. After update our gitian system to Bionic, the
compiler should support HIGH_ENTROPY_VA

Backport of core PR13764.

Depends on D5609.

Test Plan:
Tested on Ubuntu 18.04 and Debian 10:

cd contrib/devtools
./test-security-check.py

cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win32.cmake
  -DBUILD_BITCOIN_SEEDER=OFF
ninja security-check

cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake
  -DBUILD_BITCOIN_SEEDER=OFF
ninja security-check

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D5610

Details

Provenance
Chun Kuan Lee <ken2812221@gmail.com>Authored on Jul 26 2018, 09:09
FabienCommitted on Mar 31 2020, 12:27
FabienPushed on Mar 31 2020, 12:27
Reviewer
Restricted Project
Differential Revision
D5610: contrib: Fix test-security-check fail in Ubuntu 18.04
Parents
rABC981786527d2a: tests: Add test for 64-bit PE, modify 32-bit test results
Branches
Unknown
Tags
Unknown