Page MenuHomePhabricator

tests: Add test for 64-bit PE, modify 32-bit test results
ClosedPublic

Authored by Fabien on Mar 30 2020, 14:50.

Details

Summary
Change the error result from `PIE` to `DYNAMIC_BASE`. And there are no
test for 64-bit, so I made one

Backport of core PR13094.

Test Plan
cd contrib/devtools
./test-security-check.py

The test would fail on recent distributions, and need another backport
to get fixed. Some security features are enabled by default on these
recent distributions.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mar 30 2020, 14:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2020, 14:50
teamcity edited the summary of this revision. (Show Details)Mar 30 2020, 14:51

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox accepted this revision.Mar 30 2020, 18:22
This revision is now accepted and ready to land.Mar 30 2020, 18:22