Page MenuHomePhabricator
Differential D5609

tests: Add test for 64-bit PE, modify 32-bit test results
ClosedPublic
Actions

Authored by Fabien on Mar 30 2020, 14:50.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING981786527d2a: tests: Add test for 64-bit PE, modify 32-bit test results
rABC981786527d2a: tests: Add test for 64-bit PE, modify 32-bit test results
Summary
Change the error result from `PIE` to `DYNAMIC_BASE`. And there are no
test for 64-bit, so I made one

Backport of core PR13094.

Test Plan
cd contrib/devtools
./test-security-check.py

The test would fail on recent distributions, and need another backport
to get fixed. Some security features are enabled by default on these
recent distributions.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13094
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10035
Build 17910: Default Diff Build & Tests
Build 17909: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 30 2020, 14:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2020, 14:50
teamcity edited the summary of this revision. (Show Details)Mar 30 2020, 14:51

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 30 2020, 14:51

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 30 2020, 15:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10035: Diff 17281.Mar 30 2020, 15:00
Fabien added a child revision: D5610: contrib: Fix test-security-check fail in Ubuntu 18.04.Mar 30 2020, 15:12
jasonbcox accepted this revision.Mar 30 2020, 18:22
This revision is now accepted and ready to land.Mar 30 2020, 18:22
Closed by commit rABC981786527d2a: tests: Add test for 64-bit PE, modify 32-bit test results (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by Fabien). · Explain WhyMar 31 2020, 12:26
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC981786527d2a: tests: Add test for 64-bit PE, modify 32-bit test results.
Fabien added a commit: rSTAGING981786527d2a: tests: Add test for 64-bit PE, modify 32-bit test results.Apr 7 2020, 23:33

Revision Contents
Changeset List

PathSize
contrib/
devtools/
37 lines

Diff 17281

View Options

contrib/devtools/test-security-check.py

Loading...