Page MenuHomePhabricator
Differential D5610

contrib: Fix test-security-check fail in Ubuntu 18.04
ClosedPublic
Actions

Authored by Fabien on Mar 30 2020, 15:12.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING98ac38dd75e7: contrib: Fix test-security-check fail in Ubuntu 18.04
rABC98ac38dd75e7: contrib: Fix test-security-check fail in Ubuntu 18.04
Summary
 - Fix test-security-check fail in Ubuntu 18.04. Those flags are enabled
by default, so we must specify -no to make the executable does 'not'
have those attributes.
 - Drop HIGH_ENTROPY_VA. After update our gitian system to Bionic, the
compiler should support HIGH_ENTROPY_VA

Backport of core PR13764.

Depends on D5609.

Test Plan

Tested on Ubuntu 18.04 and Debian 10:

cd contrib/devtools
./test-security-check.py

cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win32.cmake
  -DBUILD_BITCOIN_SEEDER=OFF
ninja security-check

cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake
  -DBUILD_BITCOIN_SEEDER=OFF
ninja security-check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13764
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10036
Build 17912: Default Diff Build & Tests
Build 17911: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 30 2020, 15:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2020, 15:12
teamcity edited the summary of this revision. (Show Details)Mar 30 2020, 15:12

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 30 2020, 15:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 30 2020, 15:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10036: Diff 17282.Mar 30 2020, 15:29
Fabien added a child revision: D5612: Remove Windows 32 bit build.Mar 30 2020, 16:48
jasonbcox accepted this revision.Mar 30 2020, 18:36
This revision is now accepted and ready to land.Mar 30 2020, 18:36
Closed by commit rABC98ac38dd75e7: contrib: Fix test-security-check fail in Ubuntu 18.04 (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by Fabien). · Explain WhyMar 31 2020, 12:27
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC98ac38dd75e7: contrib: Fix test-security-check fail in Ubuntu 18.04.
Fabien added a commit: rSTAGING98ac38dd75e7: contrib: Fix test-security-check fail in Ubuntu 18.04.Apr 7 2020, 23:33

Revision Contents
Changeset List

PathSize
contrib/
devtools/
2 lines
20 lines

Diff 17282

View Options

contrib/devtools/security-check.py

Loading...
View Options

contrib/devtools/test-security-check.py

Loading...