Page MenuHomePhabricator

Remove check for thread_local in build systems
ClosedPublic

Authored by deadalnix on Dec 22 2018, 18:57.

Details

Summary

It is part of C++11, so has become useless to check for.

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Dec 22 2018, 18:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2018, 18:57
Herald added a subscriber: schancel. · View Herald Transcript
Fabien added a subscriber: Fabien.Dec 22 2018, 22:33

LGTM. Tested with make/cmake and gcc/clang.
Can you check why the build has failed ?

jasonbcox accepted this revision.Dec 29 2018, 01:10
jasonbcox added a subscriber: jasonbcox.

I reran the build for you. Looks like it was a spurious failure with the build bot, not an issue with the codebase.

This revision is now accepted and ready to land.Dec 29 2018, 01:10
Fabien accepted this revision.Dec 29 2018, 11:54
This revision was automatically updated to reflect the committed changes.