Page MenuHomePhabricator
Differential D8990

[backport#18665] Do not expose and consider -logthreadnames when it does not work
AbandonedPublic
Actions

Authored by majcosta on Jan 20 2021, 16:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

b91e4ae0d8ab2ae6b77585c97c52d825f56ed539 Do not expose and consider -logthreadnames when it does not work (Hennadii Stepanov)

Pull request description:

There are conditions when the `HAVE_THREAD_LOCAL` macro is undefined what causes the `-logthreadnames` option does not work -- instead of thread names empty strings `[]` only are printed in the `debug.log` file.

This PR does not exposes the `-logthreadnames` option in such cases.

Refs:
- #16059
- #18652

Backport of Core PR18665

Test Plan
ninja all check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Jan 20 2021, 16:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2021, 16:57
majcosta requested review of this revision.Jan 20 2021, 16:57
teamcity edited the summary of this revision. (Show Details)Jan 20 2021, 16:57
Harbormaster completed remote builds in B14881: Diff 27143.Jan 20 2021, 17:16
PiRK added a subscriber: PiRK.Jan 21 2021, 07:50

I skipped this one because I wasn't sure how to define HAVE_THREAD_LOCAL, and whether we needed to define it at all.

Core does this (mingw32 and FreeBSD): https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L1019

Fabien requested changes to this revision.Jan 21 2021, 08:47
Fabien added a subscriber: Fabien.

Indeed, see D2219 and D5540

This revision now requires changes to proceed.Jan 21 2021, 08:47
majcosta abandoned this revision.Jan 21 2021, 11:57

oh, looks like this one isn't helpful then. abandoning.

Revision Contents
Changeset List

PathSize
src/
6 lines

Diff 27143

View Options

src/init.cpp

Loading...