Page MenuHomePhabricator
Differential D5622

depends: xtrans: Configure flags cleanup.
ClosedPublic
Actions

Authored by Fabien on Mar 31 2020, 16:35.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING7336644abe0c: depends: xtrans: Configure flags cleanup.
rABC7336644abe0c: depends: xtrans: Configure flags cleanup.
Summary
xtrans does not understand the --with-pic and --disable-shared flags we
pass it because it is not a library. Instead, we should pass it flags
that disable features/packages we're not using so they don't get a
chance to sneak in.

Backport of core PR16183.

Test Plan

Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR16183
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10055
Build 17945: Default Diff Build & Tests
Build 17944: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 31 2020, 16:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 31 2020, 16:35
teamcity edited the summary of this revision. (Show Details)Mar 31 2020, 16:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 31 2020, 16:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien planned changes to this revision.Mar 31 2020, 16:36

Pending gitian builds

teamcity added a comment.Mar 31 2020, 16:36

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) started.

teamcity added a comment.Mar 31 2020, 16:36

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) started.

teamcity added a comment.Mar 31 2020, 16:36

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

teamcity added a comment.Mar 31 2020, 16:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10055: Diff 17322.Mar 31 2020, 16:47
teamcity added a comment.Mar 31 2020, 16:48

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) passed.

teamcity added a comment.Mar 31 2020, 17:00

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

teamcity added a comment.Mar 31 2020, 17:16

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) passed.

Fabien requested review of this revision.Mar 31 2020, 18:21
deadalnix accepted this revision.Mar 31 2020, 20:45
This revision is now accepted and ready to land.Mar 31 2020, 20:45
Closed by commit rABC7336644abe0c: depends: xtrans: Configure flags cleanup. (authored by Carl Dong <contact@carldong.me>, committed by Fabien). · Explain WhyApr 1 2020, 07:19
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC7336644abe0c: depends: xtrans: Configure flags cleanup..
Fabien added a commit: rSTAGING7336644abe0c: depends: xtrans: Configure flags cleanup..Apr 7 2020, 23:34

Revision Contents
Changeset List

PathSize
depends/
packages/
2 lines

Diff 17322

View Options

depends/packages/xtrans.mk

Loading...