Pass Config down to the code computing the PoW requirement.
ClosedPublic
Actions

Authored by deadalnix on Nov 15 2017, 17:49.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING456e6b0ab810: Pass Config down to the code computing the PoW requirement.
rABC456e6b0ab810: Pass Config down to the code computing the PoW requirement.

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

powconfig

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1132
Build 1132: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 15 2017, 17:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2017, 17:49

Fix the build

Harbormaster completed remote builds in B1133: Diff 1758.Nov 15 2017, 17:56

deadalnix added a child revision: D694: Use IsCashHFEnabled to activate the new DAA..Nov 15 2017, 17:59

schancel requested changes to this revision.Nov 16 2017, 01:15

schancel added inline comments.

src/pow.cpp
115 ↗	(On Diff #1758)	Why do you need the node config down here? This doesn't seem like a good idea to me.

This revision now requires changes to proceed.Nov 16 2017, 01:15

deadalnix requested review of this revision.Nov 16 2017, 01:27

deadalnix added inline comments.

src/pow.cpp
115 ↗	(On Diff #1758)	https://www.bitcoinabc.org/hf-testnet

schancel accepted this revision.Nov 16 2017, 16:28

This revision is now accepted and ready to land.Nov 16 2017, 16:28

Closed by commit rABC456e6b0ab810: Pass Config down to the code computing the PoW requirement. (authored by deadalnix). · Explain WhyNov 16 2017, 22:36

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

1 line

4 lines

3 lines

12 lines

32 lines

rpc/

mining.cpp

17 lines

test/

blockencodings_tests.cpp

13 lines

61 lines

7 lines

6 lines

14 lines

Diff 1757

View Options

src/chain.h

View Options

src/miner.h

View Options

src/miner.cpp

View Options

src/pow.h

View Options

src/pow.cpp

View Options

src/rpc/mining.cpp

View Options

src/test/blockencodings_tests.cpp

View Options

src/test/pow_tests.cpp

View Options

src/test/test_bitcoin.cpp

View Options

src/txdb.cpp

View Options

Pass Config down to the code computing the PoW requirement.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1757

src/chain.h

src/miner.h

src/miner.cpp

src/pow.h

src/pow.cpp

src/rpc/mining.cpp

src/test/blockencodings_tests.cpp

src/test/pow_tests.cpp

src/test/test_bitcoin.cpp

src/txdb.cpp

src/validation.cpp

Pass Config down to the code computing the PoW requirement.
ClosedPublic
Actions

Revision Contents
Changeset List