Page MenuHomePhabricator
Differential D715

A pack of nits in txmempool.cpp
ClosedPublic
Actions

Authored by deadalnix on Nov 25 2017, 02:38.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING5d7448223cfe: A pack of nits in txmempool.cpp
rABC5d7448223cfe: A pack of nits in txmempool.cpp
Summary

As per title.

Test Plan
make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
txmempoolhnits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1167
Build 1167: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 25 2017, 02:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2017, 02:38
Harbormaster completed remote builds in B1166: Diff 1826.Nov 25 2017, 02:38
deadalnix updated this revision to Diff 1827.Nov 25 2017, 13:50

More nits

Harbormaster completed remote builds in B1167: Diff 1827.Nov 25 2017, 13:50
deadalnix added a child revision: D716: Remove GetConfig call from removeForReorg.Nov 25 2017, 14:08
schancel added a comment.Nov 26 2017, 04:47

Looks good. One test failed, suspect it's one of the flaky ones. Rerunning and will investigate the failure.

schancel accepted this revision.Nov 26 2017, 05:58
This revision is now accepted and ready to land.Nov 26 2017, 05:58
Closed by commit rABC5d7448223cfe: A pack of nits in txmempool.cpp (authored by deadalnix). · Explain WhyNov 26 2017, 17:42
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
8 lines
175 lines

Diff 1827

View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...