Page MenuHomePhabricator
Differential D732

Delete CSeederHeaderMessage from the seeder and use CHeaderMessage instead
ClosedPublic
Actions

Authored by deadalnix on Nov 27 2017, 12:30.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING2986e39b94e1: Delete CSeederHeaderMessage from the seeder and use CHeaderMessage instead
rABC2986e39b94e1: Delete CSeederHeaderMessage from the seeder and use CHeaderMessage instead
Summary

More code reuse.

Test Plan

Build and run the seeder. Still finding peers and reporting them as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
seedermsgstart
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1194
Build 1194: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 27 2017, 12:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2017, 12:30
Harbormaster completed remote builds in B1193: Diff 1865.Nov 27 2017, 12:30
deadalnix updated this revision to Diff 1866.Nov 27 2017, 12:30

plop

Harbormaster completed remote builds in B1194: Diff 1866.Nov 27 2017, 12:30
deadalnix added a parent revision: D730: Get rid of the seeder's netbase.Nov 27 2017, 12:31
deadalnix updated this revision to Diff 1906.Dec 3 2017, 16:16

rebase

Harbormaster completed remote builds in B1227: Diff 1906.Dec 3 2017, 16:16
schancel accepted this revision.Dec 3 2017, 19:32
schancel added inline comments.
src/seeder/bitcoin.cpp
206 ↗(On Diff #1906)

I assume the magic that this is initialized with gets overwritten?

This revision is now accepted and ready to land.Dec 3 2017, 19:32
deadalnix added inline comments.Dec 3 2017, 22:32
src/seeder/bitcoin.cpp
206 ↗(On Diff #1906)

When reading, yes.

Closed by commit rABC2986e39b94e1: Delete CSeederHeaderMessage from the seeder and use CHeaderMessage instead (authored by deadalnix). · Explain WhyDec 3 2017, 22:34
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1866

View Options

src/Makefile.am

Loading...
View Options

src/seeder/bitcoin.h

Loading...
View Options

src/seeder/bitcoin.cpp

Loading...
View Options

src/seeder/messageheader.h

Loading...
View Options

src/seeder/messageheader.cpp

Loading...