Differential D5748

implements different disk sizes for different networks on intro
ClosedPublic
Actions

Authored by deadalnix on Apr 16 2020, 22:21.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING64985f922ef1: implements different disk sizes for different networks on intro
rABC64985f922ef1: implements different disk sizes for different networks on intro

Summary

Creates m_assumed_blockchain_size and m_assumed_chain_state_size on CChainParams.
Implements access to CChainParams' m_assumed_blockchain_size and m_assumed_chain_state_size on node interface.
Implements m_assumed_blockchain_size and m_assumed_chain_state_size on qt/intro via node interface.
Updates release process document with the new CChainParam's values.

Backport of core PR13216.

Test Plan

ninja check-all

Build the win64 client and run it on my windows machine.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Apr 16 2020, 22:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 16 2020, 22:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10256: Diff 18876.Apr 16 2020, 22:34

Fabien edited the summary of this revision. (Show Details)Apr 17 2020, 07:35

Fabien requested changes to this revision.Apr 17 2020, 08:18

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/chainparams.cpp
196 ↗	(On Diff #18876)	It was 220 and 4. This is a bit overestimated (I have 156G/2.3G), but would be weird to have the size reduced over time.
420 ↗	(On Diff #18876)	Current testnet is about 43GB/1.2GB

This revision now requires changes to proceed.Apr 17 2020, 08:18

deadalnix requested review of this revision.Apr 17 2020, 13:27

deadalnix added inline comments.

src/chainparams.cpp
196 ↗	(On Diff #18876)	It really doesn't matter at this point and getting these number really is a task for a bot, not a human.

Fabien accepted this revision.Apr 17 2020, 14:13

This revision is now accepted and ready to land.Apr 17 2020, 14:13

Closed by commit rABC64985f922ef1: implements different disk sizes for different networks on intro (authored by marcoagner <marco@agner.io>, committed by deadalnix). · Explain WhyApr 17 2020, 14:37

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC64985f922ef1: implements different disk sizes for different networks on intro.

deadalnix added a commit: rSTAGING64985f922ef1: implements different disk sizes for different networks on intro.May 5 2020, 19:01

Revision Contents
Changeset List

Path

Size

doc/

release-process.md

1 line

src/

11 lines

chainparams.cpp

6 lines

interfaces/

6 lines

6 lines

qt/

5 lines

40 lines

Diff 18909

doc/release-process.md

Loading...

src/chainparams.h

Loading...

src/chainparams.cpp

Loading...

src/interfaces/node.h

Loading...

src/interfaces/node.cpp

Loading...

src/qt/intro.h

Loading...

src/qt/intro.cpp

Loading...