Page MenuHomePhabricator
Differential D5788

Fix a bug where running test_runner.py --usecli would fail when built without bitcoin-cli
ClosedPublic
Actions

Authored by jasonbcox on Apr 20 2020, 22:56.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING1ea3681f8ceb: Fix a bug where running test_runner.py --usecli would fail when built without…
rABC1ea3681f8ceb: Fix a bug where running test_runner.py --usecli would fail when built without…
Summary

Introduced in D2696. The existence check for bitcoin-cli did not account for --usecli.

Depends on D5781

Test Plan
cmake -GNinja -DBUILD_BITCOIN_CLI=OFF ..
test_runner.py

This fails pre-patch and passes post-patch.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cli-not-found
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10318
Build 18457: Default Diff Build & Tests
Build 18456: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 20 2020, 22:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2020, 22:56
teamcity added a comment.Apr 20 2020, 22:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

jasonbcox mentioned this in D5784: [build-configurations] Add build-without-cli.Apr 20 2020, 22:57
jasonbcox added a child revision: D5784: [build-configurations] Add build-without-cli.Apr 20 2020, 22:57
teamcity added a comment.Apr 20 2020, 23:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10318: Diff 18977.Apr 20 2020, 23:05
deadalnix accepted this revision.Apr 20 2020, 23:17
This revision is now accepted and ready to land.Apr 20 2020, 23:17
Closed by commit rABC1ea3681f8ceb: Fix a bug where running test_runner.py --usecli would fail when built without… (authored by jasonbcox). · Explain WhyApr 20 2020, 23:24
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC1ea3681f8ceb: Fix a bug where running test_runner.py --usecli would fail when built without….
jasonbcox added a commit: rSTAGING1ea3681f8ceb: Fix a bug where running test_runner.py --usecli would fail when built without….May 5 2020, 19:03

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
2 lines

Diff 18977

View Options

test/functional/test_framework/test_node.py

Loading...